Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing] Enabling some UITests from Issues folder in Appium-11 #27255

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

NafeelaNazhir
Copy link
Contributor

Description of Change

This PR focuses on enabling and updating 7 testcases in Appium. The tests, previously ignored using Fails attribute, are reviewed, and modified to ensure they are functional with the Appium framework.We are going to enable tests in blocks in different PRs. This is the 11th group of tests enabled.

TestCases:

  • Issue 2842
  • Issue 5367
  • Issue 1219
  • Issue 10234
  • Issue 1937
  • Issue 3275
  • ScrollViewUITests

@NafeelaNazhir
Copy link
Contributor Author

@dotnet-policy-service agree company="Syncfusion, Inc."

@NafeelaNazhir NafeelaNazhir added area-testing Unit tests, device tests partner/syncfusion Issues / PR's with Syncfusion collaboration labels Jan 21, 2025
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Jan 21, 2025
Copy link
Contributor

Hey there @NafeelaNazhir! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@NafeelaNazhir NafeelaNazhir marked this pull request as ready for review January 22, 2025 09:34
@Copilot Copilot bot review requested due to automatic review settings January 22, 2025 09:34
@NafeelaNazhir NafeelaNazhir requested a review from a team as a code owner January 22, 2025 09:34

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 18 out of 22 changed files in this pull request and generated no comments.

Files not reviewed (4)
  • src/Controls/tests/TestCases.HostApp/Elements/ScrollViewCoreGalleryPage.cs: Evaluated as low risk
  • src/Controls/tests/TestCases.HostApp/Issues/Issue5367.cs: Evaluated as low risk
  • src/Controls/tests/TestCases.Shared.Tests/Tests/ScrollViewUITests.cs: Evaluated as low risk
  • src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue10234.cs: Evaluated as low risk
Comments suppressed due to low confidence (1)

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue5367.cs:10

  • [nitpick] The new name 'StringButton' is less descriptive than the original name 'ForceBigStringButton'. Consider reverting to the original name or choosing a more descriptive name.
const string ForceBigStringButton = "StringButton";
@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

[Test]
[Category(UITestCategories.Animation)]
[Category(UITestCategories.Compatibility)]
public void Issue1937Test()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is failing on Catalyst:

Expected timer ticks are greater than 30. Actual: 13
Assert.That(timerTicks1, Is.GreaterThan(30))
Expected: greater than 30
But was:  13

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jsuarezruiz , At the sample level, the timer has been started and the number of ticks has been validated. I have added a Thread.sleep after starting the timer to resolve the flakiness in the CI. Please review the fix and let me know if you have any concerns.

@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-testing Unit tests, device tests community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants