Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[salt] Fix broken links #6512

Merged
merged 2 commits into from
Jan 12, 2025
Merged

[salt] Fix broken links #6512

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a1da95
[salt] Fix broken links
marcwrobel Jan 5, 2025
2dfeda5
Update salt.md
marcwrobel Jan 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion products/salt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ alternate_urls:
- /saltstack
versionCommand: salt --version
releasePolicyLink: https://docs.saltproject.io/salt/install-guide/en/latest/topics/salt-version-support-lifecycle.html
releaseImage: https://docs.saltproject.io/salt/install-guide/en/latest/_images/salt-release-timeline.png
changelogTemplate: https://docs.saltproject.io/en/__RELEASE_CYCLE__/topics/releases/__LATEST__.html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
changelogTemplate: https://docs.saltproject.io/en/__RELEASE_CYCLE__/topics/releases/__LATEST__.html
changelogTemplate: https://docs.saltproject.io/en/latest/topics/releases/__LATEST__.html

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and removing all link tags for other cycles

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, this would produce a dead link for 3006.9 : https://docs.saltproject.io/en/latest/topics/releases/2006.9.html.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is a missing file i will prepare a PR for them for 3006.9 until that time we can add link just for 3006.9

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want, but it also may be caused by their release process and in this case won't be fixed.

In the mean time wouldn't it be better to fix the links on endoflife.date ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure :D lets merge this then when they fix their link we change our changelogtemplate

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the record saltstack/salt#67139 (comment)

eolColumn: CVE & Critical Support
eoasColumn: true
Expand Down Expand Up @@ -65,13 +64,15 @@ releases:
eol: 2024-02-25
latest: "3005.5"
latestReleaseDate: 2024-01-24
link: https://web.archive.org/web/20240521033125/https://docs.saltproject.io/en/3005/topics/releases/3005.5.html

- releaseCycle: "3004"
releaseDate: 2021-10-12
eoas: 2022-10-18
eol: 2023-04-18
latest: "3004.2"
latestReleaseDate: 2022-05-13
link: https://web.archive.org/web/20240607070921/https://docs.saltproject.io/en/3004/topics/releases/3004.2.html

---

Expand Down