Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(itests): remove HarmonyDB integration test #12407

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Aug 21, 2024

Related Issues

Proposed Changes

This commit removes the HarmonyDB integration test from Lotus. The HarmonyDB functionality is now maintained separately in the Curio project.

  • Remove itest-harmonydb test file
  • Remove YugabyteDB GitHub Action
  • Remove HarmonyDB-related configurations from test workflow

Benefits:

  • Brings us one step closer to enabling local execution of integration tests, as it removes a dependency on external services (YugabyteDB) for testing.

Checklist

Before you mark the PR ready for review, please make sure that:

This commit removes the HarmonyDB integration test from Lotus. The HarmonyDB functionality is now maintained separately in the Curio project.

- Remove itest-harmonydb test file
- Remove YugabyteDB GitHub Action
- Remove HarmonyDB-related configurations from test workflow
@rjan90 rjan90 added the skip/changelog This change does not require CHANGELOG.md update label Aug 21, 2024
@rjan90 rjan90 requested review from magik6k, LexLuthr and snadrus August 21, 2024 07:06
@LexLuthr
Copy link
Contributor

@snadrus I think we can remove metrics from lotus as well. HarmonyDB is used for only DBIndex here. This would also allow us to update metrics on Curio side without a conflict.

@rjan90 rjan90 marked this pull request as ready for review August 22, 2024 10:26
@rjan90
Copy link
Contributor Author

rjan90 commented Aug 28, 2024

@snadrus ping on the comments that Lex added

Copy link
Collaborator

@ribasushi ribasushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LexLuthr hijacking someone elses PR and pushing your own changes and then ✅ them is... wrong, on multiple layers.

Nevertheless - the changeset itself seems correct (doesn't excuse how it was arrived at ‼️)

:shipit:

Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm but @LexLuthr's commit message will either need to be changed or this PR squashed into a single commit

@rjan90 rjan90 merged commit 665cd01 into master Sep 3, 2024
83 checks passed
@rjan90 rjan90 deleted the phi/remove-harmonyDB-test branch September 3, 2024 07:51
ribasushi added a commit to ribasushi/ci-abusing-lotus-fork that referenced this pull request Sep 3, 2024
ribasushi added a commit to ribasushi/ci-abusing-lotus-fork that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog This change does not require CHANGELOG.md update
Projects
Status: ☑️ Done (Archive)
Development

Successfully merging this pull request may close these issues.

4 participants