-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(itests): remove HarmonyDB integration test #12407
Conversation
This commit removes the HarmonyDB integration test from Lotus. The HarmonyDB functionality is now maintained separately in the Curio project. - Remove itest-harmonydb test file - Remove YugabyteDB GitHub Action - Remove HarmonyDB-related configurations from test workflow
@snadrus I think we can remove metrics from lotus as well. HarmonyDB is used for only DBIndex here. This would also allow us to update metrics on Curio side without a conflict. |
@snadrus ping on the comments that Lex added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LexLuthr hijacking someone elses PR and pushing your own changes and then ✅ them is... wrong, on multiple layers.
Nevertheless - the changeset itself seems correct (doesn't excuse how it was arrived at
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sgtm but @LexLuthr's commit message will either need to be changed or this PR squashed into a single commit
Related Issues
Proposed Changes
This commit removes the HarmonyDB integration test from Lotus. The HarmonyDB functionality is now maintained separately in the Curio project.
Benefits:
Checklist
Before you mark the PR ready for review, please make sure that: