feat(metric-issues): Add lastChecked to OpenPeriods #83969
Merged
+53
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
snigdhas
added a commit
that referenced
this pull request
Jan 23, 2025
Add the new field to the GroupOpenPeriod definition. The backend change that adds this field is #83969
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #83969 +/- ##
==========================================
+ Coverage 87.62% 87.66% +0.03%
==========================================
Files 9530 9539 +9
Lines 542679 546683 +4004
Branches 21259 21259
==========================================
+ Hits 475508 479234 +3726
- Misses 66804 67082 +278
Partials 367 367 |
ceorourke
approved these changes
Jan 24, 2025
snigdhas
added a commit
that referenced
this pull request
Jan 24, 2025
Use the lastChecked field added in #83969 to show a more accurate value for the last_seen on an issue. This is easier to handle on the frontend than overloading the last_seen on the backend, which is generally treated as the timestamp of the latest event/occurrence. Extra context: > Metric issues only send a new occurrence when the alert threshold changes. This means an alert can be open at CRITICAL level for 2h and the last_seen on the group would be 2 hours ago. Behind the scenes, the snuba query processor would be checking this value more frequently. This new field, lastChecked is a new field intended to track a closer estimate of when the snuba query was processed. for open periods that are resolved, we can set lastChecked to the resolution time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metric issues only send a new occurrence when the alert threshold changes. This means an alert can be open at CRITICAL level for 2h and the last_seen on the group would be 2 hours ago. Behind the scenes, the snuba query processor would be checking this value more frequently. This new field,
lastCheckedis a new field intended to track a closer estimate of when the snuba query was processed. for open periods that are resolved, we can setlastCheckedto the resolution time.