-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new templates examples for Talos and Flatcar #300
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Gabriel Almeida <[email protected]> Signed off the changes
Welcome @gcezaralmeida! |
/lgtm |
Pull Request Test Coverage Report for Build 13000654571Details
💛 - Coveralls |
@qinqon Can you approve? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/cancel lgtm /ok-to-test |
@gcezaralmeida - please run make check-gen It will generate 4 new files under |
@gcezaralmeida - please look at #302 - and this comment. WDYT? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gcezaralmeida, qinqon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I like the idea of adding the the SSH key, since it is an issue with flatcar now. I would approve that. I also re-based and added the missing files. |
@nunnatsa It is failing for "e2e / integration (pull_request_target)". Can you help to check? |
Signed-off-by: Gabriel Almeida [email protected]
Signed off the changes
What this PR does / why we need it:
Add new templates examples for Talos and Flatcar.
Which issue this PR fixes : fixes #298
Special notes for your reviewer:
Release notes:
@qinqon