-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add template for Flatcar clusters #302
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: johananl The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Pull Request Test Coverage Report for Build 12691238299Details
💛 - Coveralls |
6c55930
to
ed67fd2
Compare
|
ed67fd2
to
aaeba7e
Compare
Signed-off-by: Johanan Liebermann <[email protected]>
aaeba7e
to
cd8bd82
Compare
/ok-to-test |
Huh. I was unaware of the other PR 😮 AFAICT they serve the same purpose. The two templates do have some minor differences, the main one being that my template allows SSH-ing into Flatcar nodes whereas the other template doesn't (that's because CAPK's automatic injection of SSH public keys is tailored for cloud-init whereas Flatcar uses Ignition). I don't have a strong opinion which template to use as long as it works. I based my template on I'm happy to have #300 merged and I can then rebase and add just the SSH part or any other small Flatcar-specific tweaks if that helps. |
What this PR does / why we need it: This PR adds a cluster template for workload clusters running Flatcar Container Linux.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): NoneSpecial notes for your reviewer: None
Release notes: