Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable go vet in CI #116

Merged
merged 6 commits into from
Jan 17, 2024
Merged

Conversation

patriciareinoso
Copy link
Contributor

Enable all go vet analyzers in CI except for fieldalignment which fails.
Fixes nilness, shadow, unsedresult and unsedwrite errors.

Signed-off-by: Patricia Reinoso <[email protected]>
@onf-bot
Copy link
Contributor

onf-bot commented Jan 12, 2024

Can one of the admins verify this patch?

2 similar comments
@onf-bot
Copy link
Contributor

onf-bot commented Jan 12, 2024

Can one of the admins verify this patch?

@onf-bot
Copy link
Contributor

onf-bot commented Jan 12, 2024

Can one of the admins verify this patch?

@gab-arrobo
Copy link
Contributor

ok to test

Copy link
Contributor

@gab-arrobo gab-arrobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 (tested changes with AiaB)

@gab-arrobo gab-arrobo merged commit 5de48e6 into omec-project:main Jan 17, 2024
6 of 7 checks passed
@patriciareinoso patriciareinoso deleted the enable-go-vet branch January 23, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants