Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [OSM-2368] more robust test case for python(pip) acceptance tests #5661

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

gemaxim
Copy link
Contributor

@gemaxim gemaxim commented Jan 9, 2025

Pull Request Submission Checklist

  • Follows CONTRIBUTING guidelines
  • Includes detailed description of changes
  • Contains risk assessment (Low | Medium | High)
  • Highlights breaking API changes (if applicable)
  • Links to automated tests covering new functionality
  • Includes manual testing instructions (if necessary)
  • Updates relevant GitBook documentation (PR link: ___)

What does this PR do?

Only adds pip acceptance tests.

Adds more robust test cases for pip acceptance tests.

  • one fixture that works with all platforms the acceptance tests are ran on
  • some forms of requirement specifiers behave differently on different platforms. To also include these (local paths, whl files, urls for whl files that are specific to os and arch), different fixture workspaces were added . they will run only on their correspondent os and arch.

Where should the reviewer start?

Newly added workspaces.

How should this be manually tested?

This is intended for acceptance tests. However, the tests can also be ran locally with jest.

@gemaxim gemaxim force-pushed the test/OSM-2368/python-acceptance-tests branch 12 times, most recently from e95c94c to 7748f3f Compare January 13, 2025 08:19
@gemaxim gemaxim self-assigned this Jan 13, 2025
@gemaxim gemaxim force-pushed the test/OSM-2368/python-acceptance-tests branch from 7748f3f to e015d24 Compare January 13, 2025 08:49
@gemaxim gemaxim marked this pull request as ready for review January 13, 2025 08:49
@gemaxim gemaxim requested a review from a team as a code owner January 13, 2025 08:49
@gemaxim gemaxim changed the title test: [OSM-2368] more robust test case for python acceptance tests test: [OSM-2368] more robust test case for python(pip) acceptance tests Jan 13, 2025
@gemaxim gemaxim merged commit a3a960b into main Jan 13, 2025
8 checks passed
@gemaxim gemaxim deleted the test/OSM-2368/python-acceptance-tests branch January 13, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants