Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow @tc39-staging to modify features.txt #3940

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Conversation

syg
Copy link
Contributor

@syg syg commented Oct 9, 2023

This came up while working on the V8 test262 2-way sync bot for staging/. It is likely that tests added to staging/ will be for a new feature that requires a new entry in features.txt, so the staging group should have write access to that file.

cc @rmahdav

@syg syg requested a review from a team as a code owner October 9, 2023 20:29
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me

@ljharb ljharb requested a review from a team October 9, 2023 20:33
@syg
Copy link
Contributor Author

syg commented Oct 9, 2023

An alternative here is to just... not lint it. I guess the downside is typos are more likely? Does anyone recall the rationale for why there's an list of allowed features in the first place?

@ljharb
Copy link
Member

ljharb commented Oct 9, 2023

I would assume it's because it was a common problem that people would typo feature names, and, that having a list ensures that there's a central place for discovery.

Copy link
Contributor

@Ms2ger Ms2ger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine by me, but maybe give it a little longer before merging

@Ms2ger Ms2ger merged commit a9821b4 into tc39:main Oct 12, 2023
@ptomato
Copy link
Contributor

ptomato commented Oct 26, 2023

This has the unexpected (to me, at least) side effect that the tc39-staging team will get pinged for a review every time someone modifies features.txt. Seems harmless, but just mentioning it in case anyone wonders why it's happening.

@syg
Copy link
Contributor Author

syg commented Oct 27, 2023

This has the unexpected (to me, at least) side effect that the tc39-staging team will get pinged for a review every time someone modifies features.txt. Seems harmless, but just mentioning it in case anyone wonders why it's happening.

Seems like a positive side effect to me tbh. I appreciate being pinged on when new feature tests land.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants