-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow @tc39-staging to modify features.txt #3940
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense to me
An alternative here is to just... not lint it. I guess the downside is typos are more likely? Does anyone recall the rationale for why there's an list of allowed features in the first place? |
I would assume it's because it was a common problem that people would typo feature names, and, that having a list ensures that there's a central place for discovery. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine by me, but maybe give it a little longer before merging
8ef2e77
to
8468f3b
Compare
This has the unexpected (to me, at least) side effect that the tc39-staging team will get pinged for a review every time someone modifies |
Seems like a positive side effect to me tbh. I appreciate being pinged on when new feature tests land. |
This came up while working on the V8 test262 2-way sync bot for
staging/
. It is likely that tests added to staging/ will be for a new feature that requires a new entry infeatures.txt
, so the staging group should have write access to that file.cc @rmahdav