-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(azure-storage-blob): add raw support #442
base: main
Are you sure you want to change the base?
Conversation
Thanks for PR!
|
azure-storage-blob
add getItemRaw
support
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #442 +/- ##
==========================================
+ Coverage 65.05% 66.33% +1.27%
==========================================
Files 39 39
Lines 4055 4117 +62
Branches 487 509 +22
==========================================
+ Hits 2638 2731 +93
+ Misses 1408 1377 -31
Partials 9 9 β View full report in Codecov by Sentry. |
I wasn't sure about extracting and reusing the fn, since when I reviewed all the other
I unfortunately don't know enough about how to do that, but can do some digging at some point if it helps.
Adding tests, would be a separate issue and not a blocker for this change, right? |
For setItemRaw, it seems that our driver implementation will be the same. But we need to set it. see here for what happens.
Since this is a live driver with already tests, i prefer that we add a reasonable test that verifies this feature. |
Hello team, is there any plans to complete this PR, or should I open a new one if I'd like to have this functionality? |
π Linked issue
#441
β Type of change
π Description
Adds support for
getItemRaw
inazure-storage-blob
π Checklist
Functions are not documented