Editorial: Correct a "set" to "let" #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This use introduces the variable, so it must be "set" (and grammatically it didn't make sense before, so this is merely a typo).
shannonbooth
reviewed
Jan 8, 2025
| @@ -1324,7 +1324,7 @@ To <dfn>parse a pattern string</dfn> given a [=/pattern string=] |input|, [=/opt | |||
| </dl> | |||
| </div> | |||
| 1. If |open token| is not null: | |||
| 1. Set |prefix| be the result of running [=consume text=] given |parser|. | |||
| 1. Let |prefix| be the result of running [=consume text=] given |parser|. | |||
| 1. Set |name token| to the result of running [=try to consume a token=] given |parser| and "<a for=token/type>`name`</a>". | |||
| 1. Set |regexp or wildcard token| to the result of running [=try to consume a regexp or wildcard token=] given |parser| and |name token|. | |||
| 1. Let |suffix| be the result of running [=consume text=] given |parser|. | |||
There was a problem hiding this comment.
I can't comment on the exact line, but I believe step 6 just below should also be changed to "Let":
1. Set |modifier token| to the result of running [=try to consume a modifier token=] given |parser|.
There was a problem hiding this comment.
Yeah this looks also a typo.
sisidovski
approved these changes
Jan 9, 2025
| @@ -1324,7 +1324,7 @@ To <dfn>parse a pattern string</dfn> given a [=/pattern string=] |input|, [=/opt | |||
| </dl> | |||
| </div> | |||
| 1. If |open token| is not null: | |||
| 1. Set |prefix| be the result of running [=consume text=] given |parser|. | |||
| 1. Let |prefix| be the result of running [=consume text=] given |parser|. | |||
| 1. Set |name token| to the result of running [=try to consume a token=] given |parser| and "<a for=token/type>`name`</a>". | |||
| 1. Set |regexp or wildcard token| to the result of running [=try to consume a regexp or wildcard token=] given |parser| and |name token|. | |||
| 1. Let |suffix| be the result of running [=consume text=] given |parser|. | |||
There was a problem hiding this comment.
Yeah this looks also a typo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This use introduces the variable, so it must be "set" (and grammatically it didn't make sense before, so this is merely a typo).
Partially addresses #242.
Preview | Diff