Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Correct a "set" to "let" #249

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Editorial: Correct a "set" to "let" #249

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d77ad4
Editorial: Correct a "set" to "let"
jeremyroman Jan 8, 2025
06d924d
and one more
jeremyroman Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spec.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1324,7 +1324,7 @@ To <dfn>parse a pattern string</dfn> given a [=/pattern string=] |input|, [=/opt
</dl>
</div>
1. If |open token| is not null:
1. Set |prefix| be the result of running [=consume text=] given |parser|.
1. Let |prefix| be the result of running [=consume text=] given |parser|.
1. Set |name token| to the result of running [=try to consume a token=] given |parser| and "<a for=token/type>`name`</a>".
1. Set |regexp or wildcard token| to the result of running [=try to consume a regexp or wildcard token=] given |parser| and |name token|.
1. Let |suffix| be the result of running [=consume text=] given |parser|.
Copy link

@shannonbooth shannonbooth Jan 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't comment on the exact line, but I believe step 6 just below should also be changed to "Let":

  1. Set |modifier token| to the result of running [=try to consume a modifier token=] given |parser|.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this looks also a typo.

Expand Down